Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorize the calls to the write filter per element #210

Merged
merged 1 commit into from
Jan 13, 2024
Merged

factorize the calls to the write filter per element #210

merged 1 commit into from
Jan 13, 2024

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Jan 7, 2024

We can add generic code in there. In particular it allows libmatroska to do extra filter that may not be welcome in the more generic libebml.

@robUx4
factorize the calls to the write filter per element
ad4c5fb 
We can add generic code in there.
@robUx4 robUx4 added api-break breaks the API (e.g. programs using it will have to adjust their source code) abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) labels Jan 7, 2024
@robUx4 robUx4 marked this pull request as ready for review January 7, 2024 10:19
This was referenced Jan 7, 2024
Closed
Draft
@robUx4 robUx4 merged commit c5d85c4 into Matroska-Org:master Jan 13, 2024
15 checks passed
@robUx4 robUx4 deleted the virtual_filter branch January 13, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) api-break breaks the API (e.g. programs using it will have to adjust their source code)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robUx4